Refresh package install after pausing it during updation #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenrewar
force-pushed
the
cli-pkg-install-update
branch
from
576716e to
9a7304d
Compare
praveenrewar
changed the title
praveenrewar
commented
Oct 11, 2022
praveenrewar
force-pushed
the
cli-pkg-install-update
branch
from
9a7304d to
c77b87d
Compare
100mik
reviewed
Oct 18, 2022
After a package install is paused successfully, the observedGeneration is updated resulting in conflicts while updating the package install
praveenrewar
force-pushed
the
cli-pkg-install-update
branch
from
c77b87d to
06002d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refresh package install after pausing it during updation.
Pausing a package install causes a change in observedGeneration, due to this it needs to be refreshed to be able to update it later on.
Which issue(s) this PR fixes:
Fixes #924
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: