Refactor app/pkg init logic #913

100mik · 2022-09-29T23:48:12Z

What this PR does / why we need it:

Refactors and cleans up app/package init logic

Which issue(s) this PR fixes:

Fixes #827

Does this PR introduce a user-facing change?

NONE

Review Checklist:

Follows the developer guidelines
Relevant tests are added or updated
Relevant docs in this repo added or updated
Relevant carvel.dev docs added or updated in a separate PR and there's
a link to that PR
Code is at least as readable and maintainable as it was before this
change

Additional documentation e.g., Proposal, usage docs, etc.:

100mik · 2022-09-29T23:49:19Z

Gotta work towards wrapping up pending cleanup on this through a bunch of reviews @praveenrewar

cli/pkg/kctrl/cmd/package/init/pkg_build.go

cli/pkg/kctrl/cmd/app/init/git.go

…adcode

cli/pkg/kctrl/local/sources/fetch.go

cli/pkg/kctrl/local/sources/vendir_runner.go

…nced. Removing stale comments

cli/pkg/kctrl/cmd/package/init.go

cli/pkg/kctrl/local/sources/git.go

…n files cleaner

…o. Refactoring init files

…passing contents down the function tree

cli/pkg/kctrl/cmd/package/init.go

cli/pkg/kctrl/cmd/package/repository/release/release.go

cli/pkg/kctrl/local/buildconfigs/pkg_build.go

cli/pkg/kctrl/local/sources/template.go

cli/pkg/kctrl/local/sources/vendir_runner.go

… duplicate dependencies

praveenrewar

LGTM!

vmwclabot added the cla-not-required label Sep 29, 2022

100mik changed the title ~~Kctrl init refactor~~ Refactor app/pkg init logic Sep 29, 2022

rohitagg2020 reviewed Oct 4, 2022

View reviewed changes

cli/pkg/kctrl/cmd/package/init/pkg_build.go Outdated Show resolved Hide resolved

rohitagg2020 reviewed Oct 4, 2022

View reviewed changes

cli/pkg/kctrl/cmd/app/init/git.go Outdated Show resolved Hide resolved

cli/pkg/kctrl/cmd/app/init/git.go Outdated Show resolved Hide resolved

100mik force-pushed the kctrl-init-refactor branch 2 times, most recently from 0e96e53 to a576172 Compare October 17, 2022 20:50

100mik added 18 commits October 19, 2022 01:47

Scope logic dealing with vendir.yml to VendirConfig

eec4d9c

Refactor how Fetch is configured. Move build scoped fucntions to build.

c69f1b4

Split VendirStep into VendirRunner and VendirConfigBuilder. Remove de…

0665334

…adcode

Refactor git step. Remove deadcode.

a3b0e59

Refactor GithubStep

6db6fac

Remove unused create step and refactor necessarily in app init

006bc45

Refactor GitStep

15e37bd

Dedup app init logic. configureAppBuild => getAppBuildName

ace1555

Refactor TemplateStep

8d42d2c

Remove step interface and move Build interface

19c06e1

Refactoring package init

5e63be4

Add missing deffered cleanup

1a2dbba

Remove file_utils. Use builins instead

abc6de8

Add check while running vendir sync to handle local directory case

26a7139

Merge VendirCOnfiguration into FetchConfiguation

deae808

Move PackageBuild and AppBuild to buildconfigs

eb8e34f

Move vendir config and related objects to sources package

8495c0b

Move init command files out of a separate package

748d492

100mik force-pushed the kctrl-init-refactor branch from f3ca798 to 748d492 Compare October 18, 2022 20:21

100mik added 2 commits October 19, 2022 03:10

Remove dependency of annotation for storing fetch mode

0bbdd48

Moving constants to appropriate locations

8a78a08

praveenrewar reviewed Oct 19, 2022

View reviewed changes

Returning a non-pointer value from GetExport as it is always derefere…

7260b52

…nced. Removing stale comments

praveenrewar reviewed Oct 19, 2022

View reviewed changes

100mik added 3 commits October 20, 2022 13:16

Stricter checks before running vendir sync. Making not exists check o…

0dd7fcb

…n files cleaner

Move source specific configuration to source.go. fetch.go => source.g…

574e6f5

…o. Refactoring init files

Remove unnecessary dependency on carvel-kapp-controller/.../exec package

31b0778

100mik force-pushed the kctrl-init-refactor branch from 4e6464b to 31b0778 Compare October 20, 2022 08:17

Use vendirConfig.Contents while configuring package build instead of …

59597df

…passing contents down the function tree

praveenrewar reviewed Oct 20, 2022

View reviewed changes

100mik added 2 commits October 20, 2022 16:12

Move logic for initialising deploy section to build interface. Remove…

c966db9

… duplicate dependencies

TemplateConfiguration => Template. Othere refactoring.

6d20f07

100mik marked this pull request as ready for review October 20, 2022 11:17

praveenrewar approved these changes Oct 20, 2022

View reviewed changes

100mik merged commit 4984835 into carvel-dev:develop Oct 20, 2022

100mik deleted the kctrl-init-refactor branch October 20, 2022 11:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor app/pkg init logic #913

Refactor app/pkg init logic #913

100mik commented Sep 29, 2022 •

edited

Loading

100mik commented Sep 29, 2022

praveenrewar left a comment

Refactor app/pkg init logic #913

Refactor app/pkg init logic #913

Conversation

100mik commented Sep 29, 2022 • edited Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?

Review Checklist:

Additional documentation e.g., Proposal, usage docs, etc.:

100mik commented Sep 29, 2022

praveenrewar left a comment

Choose a reason for hiding this comment

100mik commented Sep 29, 2022 •

edited

Loading