Sort out S3Path.toString() behaviour

[jose-martinez-fineos]

Task Description

The implementation of S3Path.toString() is returning the URI (for this we already have the toURI() method). AFAIK the implementation of Path.toString() for Linux/Windows file system doesn't add the scheme (file:///). I think the S3Path should follow that approach. Other concern is that the creation of a S3Path uses a bucket + key, and if the toString returns more than that, we cannot create a S3Path using that (yes, there are ways to do that, but I prefer to keep it simple if possible). Hope this helps!

Tasks

The following tasks will need to be carried out:

• Investigate the issue.
• Implement a fix.
• Test.

Task Relationships

This task:

• Is a sub-task of: #
• Depends on: #
• Is a follow-up of: #
• Relates to: #

Useful Links

Help

• Points of contact:
  • @carlspring
  • @steve-todorov

[steve-todorov]

I agree with your findings. The NIO interface and implementations for UnixPath and WindowsPath do not include the schema:// part. It sounds reasonable for us to align the implementation with the NIO interface. Furthermore, there is also a dedicated toUri() method that already returns the URI.

This will introduce a breaking change, but on the other side a lot of people might use the Path.toString() as a reference point for database records (i.e. to store the object key together with the bucket).

A PR to resolve this has been opened: #875