Skip to content

feat(ui): Confirm/Reset buttons under signing screen #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Jun 5, 2025

Description

Please include a summary of the changes and a brief description about this PR

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Screen.Recording.2025-06-05.at.18.01.50.mov

Android

Screen.Recording.2025-06-05.at.18.10.01.mov

@Sotatek-DukeVu Sotatek-DukeVu self-assigned this Jun 5, 2025
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in DM, just a few style notes:

  • The input box disappeared. It should have Neutral 100 background with Primary 700 border.
  • The input text seems to be aligned to the center, it should be to the left.
  • The Cancel button should be Neutral 700 instead of 800 (please check if this needs to be adjusted globally in the entire app).

Unit tests for this component as it seems we missed a few things but I know we're already fixing it on another PR.

@Sotatek-DukeVu Sotatek-DukeVu force-pushed the feat/DTIS-1332-confirm-reset-button-under-signing-screen branch from 1f2c1b6 to 0d37889 Compare June 5, 2025 10:29
@Sotatek-DukeVu Sotatek-DukeVu force-pushed the feat/DTIS-1332-confirm-reset-button-under-signing-screen branch from 0d37889 to 5c0b2f7 Compare June 5, 2025 10:57
@sdisalvo-crd sdisalvo-crd requested a review from obstar June 5, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants