-
Notifications
You must be signed in to change notification settings - Fork 350
CIP-0010 | Add label: CIP-0072 (dApp registration & Discovery) #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defined in CIP-0072 draft here: https://github.com/ehanoc/CIPs/blob/cip-72_dapp-registration/CIP-0072/README.md#metadata-label
Is there any reason why this change to CIP-10 cannot be included in the CIP-72? PR? do we want to encourage PRs per CIP change? @rphair |
@Ryun1 I thought that merging it separately, and prior to #355, would allow @matiwinnetou and others to perform testing scenarios using the actual metadata label. This seemed important given the age of the CIP PR (currently just over 6 months) and I didn't want to make them wait longer for a metadata label. This of course assumes it won't be disputed that CIP-0072 will need a metadata label (currently I think the CIP clearly calls for it), or won't be invalidated or deprecated somehow. For the general case, what I generalised from prior |
@rphair thanks for the great response; as always. To me, this approach makes perfect sense, that fills in my gap in understanding - thanks. |
yes, @Ryun1 @KtorZ please green-check this as well so we can merge it ASAP... I never would have guessed CIP-0072 was in danger of getting merged first 😅 which somewhat invalidates my argument in #505 (comment) but I guess you never know what will happen in the real world. 😜 |
required by already-merged cardano-foundation#355
required by already-merged cardano-foundation#355
No description provided.