Skip to content

CIP-0010 | Add label: CIP-0072 (dApp registration & Discovery) #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

matiwinnetou
Copy link
Contributor

No description provided.

@rphair rphair changed the title CIP-72: dApp Registration & Discovery CIP-0010 | Add label: dApp Registration & Discovery Apr 17, 2023
@rphair rphair added the CIP-0010: new registry entry Adding a new entry to the metadata label registry label Apr 17, 2023
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rphair rphair changed the title CIP-0010 | Add label: dApp Registration & Discovery CIP-0010 | Add label: CIP-72: dApp registration & Discovery Apr 17, 2023
@rphair rphair changed the title CIP-0010 | Add label: CIP-72: dApp registration & Discovery CIP-0010 | Add label: CIP-0072 (dApp registration & Discovery) Apr 17, 2023
@Ryun1
Copy link
Collaborator

Ryun1 commented Apr 21, 2023

Is there any reason why this change to CIP-10 cannot be included in the CIP-72? PR? do we want to encourage PRs per CIP change? @rphair

@rphair
Copy link
Collaborator

rphair commented Apr 21, 2023

@Ryun1 I thought that merging it separately, and prior to #355, would allow @matiwinnetou and others to perform testing scenarios using the actual metadata label. This seemed important given the age of the CIP PR (currently just over 6 months) and I didn't want to make them wait longer for a metadata label.

This of course assumes it won't be disputed that CIP-0072 will need a metadata label (currently I think the CIP clearly calls for it), or won't be invalidated or deprecated somehow.

For the general case, what I generalised from prior CIP-0010 requests was that labels can be added if a project or its representative makes a public case that they are needed, and that this doesn't have to be done with a CIP (many of our labels have no associated CIP).

@Ryun1
Copy link
Collaborator

Ryun1 commented Apr 21, 2023

@rphair thanks for the great response; as always.

To me, this approach makes perfect sense, that fills in my gap in understanding - thanks.

@matiwinnetou
Copy link
Contributor Author

@Ryun1 @rphair @KtorZ - please merge this as well...

@rphair
Copy link
Collaborator

rphair commented Jun 9, 2023

yes, @Ryun1 @KtorZ please green-check this as well so we can merge it ASAP... I never would have guessed CIP-0072 was in danger of getting merged first 😅 which somewhat invalidates my argument in #505 (comment) but I guess you never know what will happen in the real world. 😜

@rphair rphair merged commit 51a4c28 into cardano-foundation:master Jun 19, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Jul 28, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIP-0010: new registry entry Adding a new entry to the metadata label registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants