Skip to content

CIP-0005 | Define bech32 prefixes for extended pool operator keys #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025

Conversation

gitmachtl
Copy link
Contributor

@gitmachtl gitmachtl commented May 13, 2025

CIP-0005 does not specify bech32 prefixes for extended pool operator keys.

These were added to cardano-api with IntersectMBO/cardano-api#781 and is now part of cardano-cli with IntersectMBO/cardano-cli#1091 (addresses IntersectMBO/cardano-cli#1076)

This PR modifies CIP-0005 to define a standard set of prefixes for them:

  • pool_xsk for pool operator extended signing key
  • pool_xvk for pool operator extended verification key

Other changes:

  • Added cardano-signer to the list of tools (acceptance criteria)
  • Added an entry in the Changelog table
  • Corrected the false date of the ID=1 entry in the Changelog table from 2024 to 2025

gitmachtl added 2 commits May 13, 2025 21:55
https://cips.cardano.org/cip/CIP-0005 does not specify bech32 prefixes for extended pool operator keys. These were added to cardano-api with IntersectMBO/cardano-api#781 and part of cardano-cli with IntersectMBO/cardano-cli#1091 

This PR modifies CIP-0005 to define a standard set of prefixes for them.

Other changes:
- Added [https://github.com/gitmachtl/cardano-signer](cardano-signer) to the list of tools (acceptance criteria)
- Added an entry in the Changelog table
@gitmachtl gitmachtl marked this pull request as ready for review May 13, 2025 20:05
@rphair rphair added the Category: Tools Proposals belonging to the 'Tools' category. label May 14, 2025
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks in order from the API & CLI repository references... thanks @gitmachtl for covering this in the CIP.

@rphair rphair added the State: Last Check Review favourable with disputes resolved; staged for merging. label May 14, 2025
@rphair rphair requested review from Ryun1 and Crypto2099 May 14, 2025 04:41
Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rphair rphair merged commit bc6bc74 into cardano-foundation:master May 20, 2025
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Tools Proposals belonging to the 'Tools' category.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants