Skip to content

chore: deprecate emptystate v2 prop #7810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

davidmenendez
Copy link
Contributor

Closes #7424

@davidmenendez davidmenendez requested a review from a team as a code owner July 8, 2025 18:48
@davidmenendez davidmenendez requested review from anamikaanu96 and amal-k-joy and removed request for a team July 8, 2025 18:48
Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 4858cea
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/68700a2f3ebb0e0008b54a54
😎 Deploy Preview https://deploy-preview-7810--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 4858cea
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/68700a2e3b41eb0008c4e86b
😎 Deploy Preview https://deploy-preview-7810--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.19%. Comparing base (076b303) to head (4858cea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7810      +/-   ##
==========================================
- Coverage   84.24%   84.19%   -0.05%     
==========================================
  Files         443      443              
  Lines       18566    18566              
  Branches     4805     4805              
==========================================
- Hits        15640    15631       -9     
- Misses       2926     2935       +9     
Components Coverage Δ
ibm-products 81.51% <ø> (-0.07%) ⬇️
ibm-products-web-components 91.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

amal-k-joy
amal-k-joy previously approved these changes Jul 10, 2025
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidmenendez ,
Everything looks good.
When we check the Storybook Props section, there's no indication that this prop is deprecated. This isn't limited to just this component but for others as well. Carbon Core uses the deprecated() method to achieve the same functionality.
cc: @elycheea
image

@elycheea
Copy link
Contributor

@amal-k-joy Good point. I think we’ve added it to the prop descriptions. I know the slug included **Experimental:**, but I do think we aren’t the most consistent in how we handle deprecated props.

See APIKeyModal:

image

See anywhere with the slug:

image image

See NotificationPanel:

image

Really not sure what’s going on with our formatting when it’s at the bottom, but definitely think we can/should look into this with our doc reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up EmptyState props and deprecations
3 participants