-
Notifications
You must be signed in to change notification settings - Fork 151
chore: deprecate emptystate v2 prop #7810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7810 +/- ##
==========================================
- Coverage 84.24% 84.19% -0.05%
==========================================
Files 443 443
Lines 18566 18566
Branches 4805 4805
==========================================
- Hits 15640 15631 -9
- Misses 2926 2935 +9
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @davidmenendez ,
Everything looks good.
When we check the Storybook Props section, there's no indication that this prop is deprecated. This isn't limited to just this component but for others as well. Carbon Core uses the deprecated()
method to achieve the same functionality.
cc: @elycheea
@amal-k-joy Good point. I think we’ve added it to the prop descriptions. I know the slug included See APIKeyModal: See anywhere with the slug: See NotificationPanel: Really not sure what’s going on with our formatting when it’s at the bottom, but definitely think we can/should look into this with our doc reviews. |
Closes #7424