updated node engine #1352
Merged
updated node engine #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidari
requested review from
tw15egan and
jharvey10
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alisonjoseph
approved these changes
Jun 7, 2024
jharvey10
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes carbon-design-system/carbon#15356
Looks like we are using different versions when doing the deploy.
Our deploy.packages.yml file is using node 20.x, but the
design-language-websiterepo is using node 18.xI guess we can update the version in the DLW repo to 20.x like it was done in the last update in this PR and it might fix the error.
The PR was merged in October 9, 2023 and the deploy started failing after that date on October 11, 2023.