feat(HCM): add HCM mixin, use forced-colors
#8489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit ff418f4 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit ff418f4 https://deploy-preview-8489--carbon-components-react.netlify.app |
This was referenced Apr 26, 2021
Closed
|
@dakahn added in the rest if you want to take a look and confirm 👍🏻 |
dakahn
approved these changes
May 3, 2021
This was referenced May 10, 2021
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8413
Closes #8458
Updates the HCM media queries around the codebase to use a mixin, and moves the HCM to the bottom of the
.scssfiles to ensure they are not overwritten.Also uses
forced-colorswhich is fully supported in Chrome 🎉Changelog
New
@mixin high-contrast-modewhich has a few built-in styles to handle various HCM fixes. This mixin makes it easier to update the underlying media query used for HCM.forced-colorssupport, which is supported in Chrome, Edge, Safari (opt-in), and Firefox (opt-in).Changed
Removed
.scssfilesTesting / Reviewing
In Windows, enable High Contrast Mode, and open up Firefox, Chrome, and Edge. In Firefox, you will need to type
about:configin the address bar, then search forforced-colorsand set that totrue. Then, ensure each component is usable when in HCM and that all icons are displayed.