Skip to content

fix(text-input): fix letters being cut off #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2017
Merged

fix(text-input): fix letters being cut off #29

merged 1 commit into from
Apr 14, 2017

Conversation

tw15egan
Copy link
Contributor

Fix letters being cut off in text-input

Changed

  • Removed vertical padding, as the specified height takes care of this. Was leading to weird rendering issues in Firefox where letters like q,j, and y were cut off at the bottom.

@chrisdhanaraj
Copy link
Contributor

👍 merging this fix in

@chrisdhanaraj chrisdhanaraj merged commit 05b0f3b into carbon-design-system:master Apr 14, 2017
joshblack referenced this pull request in joshblack/carbon May 2, 2019
Merge pull request #29 from bthan/icons
961d6d5 
Icons
designertyler pushed a commit to designertyler/carbon that referenced this pull request Oct 14, 2019
@vpicone
feat: update to 1.7 + cleanup (carbon-design-system#29)
5ef49bb 
feat: update to 1.7 + cleanup
@dudley-ibm dudley-ibm mentioned this pull request Jun 24, 2020
Merged
@tw15egan tw15egan deleted the text-input branch April 28, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tw15egan @chrisdhanaraj