fix(checkbox/datatable): fixed checkbox checked state regression
#20070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20070 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 485 485
Lines 31370 31373 +3
Branches 5480 5430 -50
=======================================
+ Hits 28670 28673 +3
- Misses 2546 2547 +1
+ Partials 154 153 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19563
Closes #19820
Closes #20058
There was a regression problem with the
checkboxcomponent'scheckedstate not updating properly in many use cases, including the selection feature indata-table. This PR fixes this issue.Changelog
Added
.checked="${checked}"to the rendering ofcheckbox.tssince the?would only conditionally render thecheckedattribute which was the cause of this issue.Testing / Reviewing
DataTable/Selection/Defaultin the WC deploy previewDataTable/Batch Actions/Defaultin the WC deploy previewPR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Wrote passing tests that cover this changeMore details can be found in the pull request guide