-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(settings.ts): add cds-icon-button
and cds-slug
to the selectorTabbable
string
#20067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20067 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 485 485
Lines 31370 31370
Branches 5480 5430 -50
=======================================
Hits 28670 28670
- Misses 2546 2547 +1
+ Partials 154 153 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cds-icon-button
to the selectorTabbable
stringcds-icon-button
and cds-slug
to the selectorTabbable
string
Closes #20065
Changelog
New
cds-icon-button
andcds-slug
to theselectorTabbable
stringTesting / Reviewing
Verify in the
packages/web-components/src/globals/settings.ts
file.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide