Skip to content

fix(settings.ts): add cds-icon-button and cds-slug to the selectorTabbable string #20067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

makafsal
Copy link
Member

@makafsal makafsal commented Jul 31, 2025

Closes #20065

Changelog

New

  • added cds-icon-button and cds-slug to the selectorTabbable string

Testing / Reviewing

Verify in the packages/web-components/src/globals/settings.ts file.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@makafsal makafsal requested review from a team as code owners July 31, 2025 13:13
@makafsal makafsal requested review from 2nikhiltom and emyarod July 31, 2025 13:13
Copy link

netlify bot commented Jul 31, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 92e1200
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/688b813ca58de20008ba9a5f
😎 Deploy Preview https://deploy-preview-20067--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.39%. Comparing base (b56c1b8) to head (92e1200).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20067   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files         485      485           
  Lines       31370    31370           
  Branches     5480     5430   -50     
=======================================
  Hits        28670    28670           
- Misses       2546     2547    +1     
+ Partials      154      153    -1     
Flag Coverage Δ
main-packages 84.93% <ø> (ø)
web-components 97.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

netlify bot commented Jul 31, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 92e1200
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/688b813c1971e600087cfdea
😎 Deploy Preview https://deploy-preview-20067--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 31, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 92e1200
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/688b813c83f55b000898061f
😎 Deploy Preview https://deploy-preview-20067--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@makafsal makafsal changed the title fix(settings.ts): add cds-icon-button to the selectorTabbable string fix(settings.ts): add cds-icon-button and cds-slug to the selectorTabbable string Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SelectorTabbable]: cds-icon-button missing in this list
2 participants