-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(pageheader): organize stories in storybook and add documentation in overview #19520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pageheader): organize stories in storybook and add documentation in overview #19520
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19520 +/- ##
==========================================
+ Coverage 84.48% 84.57% +0.09%
==========================================
Files 373 373
Lines 14645 14675 +30
Branches 4840 4804 -36
==========================================
+ Hits 12373 12412 +39
+ Misses 2125 2116 -9
Partials 147 147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! 💥
9fff69c
Closes #19493
This PR exposes the
PageHeader
stories as experimental under the "Patterns" section of Storybook and adds technical documentationChangelog
New
Changed
pageActions
prop name inPageHeader.ContentPageActions
toactions
to make it less repetitivejustify-content: flex-end
asjustify-content: end
has been deprecatedRemoved
Content
,BreadcrumbBar
, andTabBar
stories in favor of variations of thePageHeader
with some/all of zones togetherTesting / Reviewing
Review the stories and let me know if I should remove/add any stories or controls
Review the documentation in the
Overview
section.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)[ ] Tested for cross-browser consistencyMore details can be found in the pull request guide