fix: focus and onClick issue on HeaderMenuItem

[2nikhiltom]

Closes #19436
Closes #19401

Added back the TabIndex default value to 0 if not passed

Changelog

New

Added test cases and story for testing/reviewing

Changed

sets default value to 0 inside the function body
const resolvedTabIndex = tabIndex ?? 0;

Testing / Reviewing

ci should pass
verify that HeaderMenuItem is focusable via keyboard navigation and onClick is called (verify in console )

⚠️ BEFORE MERGE ⚠️

• story to be removed before merging

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

• Reviewed every line of the diff
• Updated documentation and storybook examples
• Wrote passing tests that cover this change
• Addressed any impact on accessibility (a11y)
• Tested for cross-browser consistency
• Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

[netlify]

✅ Deploy Preview for v11-carbon-web-components ready!

Name	Link
🔨 Latest commit	d911ab0
🔍 Latest deploy log	https://app.netlify.com/projects/v11-carbon-web-components/deploys/683fe3bae905930008ad433f
😎 Deploy Preview	https://deploy-preview-19495--v11-carbon-web-components.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[netlify]

✅ Deploy Preview for v11-carbon-react ready!

Name	Link
🔨 Latest commit	d911ab0
🔍 Latest deploy log	https://app.netlify.com/projects/v11-carbon-react/deploys/683fe3bac174fa00083907e3
😎 Deploy Preview	https://deploy-preview-19495--v11-carbon-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (a975063) to head (d911ab0).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #19495   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files         373      373           
  Lines       14735    14736    +1     
  Branches     4838     4891   +53     
=======================================
+ Hits        12449    12450    +1     
+ Misses       2139     2138    -1     
- Partials      147      148    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[adamalston]

On #19436 (comment), do we know why the default was deleted?

[2nikhiltom]

Hey @adamalston
Spoke with @Gururajj77 - the change appeared to be unintentional while resolving TypeScript issues during the React v19 dependency update. commit reference

[adamalston]

Sounds good. Since that was just one change in #18207 — a pull request with over 2,500 lines of changes — should someone go through it to confirm there were no other unintentional changes? Maybe that’s unnecessary, but it doesn’t hurt to ask.

[tay1orjones]

@adamalston I looked through it again and didn't see anything of note. It's possible the tabindex change was output from one of the codemods for react 19 or the related typescript updates.

[riddhybansal]

LGTM 💯

[carbon-automation]

Hey there! v11.84.0 was just released that references this issue/PR.