fix(multi-select): adjust AI label spacing when clear button appears #19450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19450 +/- ##
==========================================
- Coverage 84.88% 84.87% -0.01%
==========================================
Files 372 372
Lines 14453 14438 -15
Branches 4705 4757 +52
==========================================
- Hits 12268 12254 -14
+ Misses 2039 2037 -2
- Partials 146 147 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
annawen1
reviewed
May 23, 2025
packages/web-components/src/components/multi-select/multi-select.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Anna Wen <[email protected]>
annawen1
approved these changes
May 23, 2025
heloiselui
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
heloiselui
approved these changes
May 26, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit May 26, 2025
d91dd77
37 checks passed
AlexanderMelox
pushed a commit
to AlexanderMelox/carbon
that referenced
this pull request
Jun 10, 2025
…arbon-design-system#19450) * fix(multi-select): adjust AI label spacing when clear button appears * Use spacing token for block-size Co-authored-by: Anna Wen <[email protected]> --------- Co-authored-by: Anna Wen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19297
Fixes overlapping buttons WCAG 2.5.8 issue in Multi Select filterable with AI label variation. Added styling on AI label that creates spacing and vertical divider matching the React version when clear button is present
New spacing:
Changelog
New
Testing / Reviewing
filterable="true"PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesWrote passing tests that cover this changeMore details can be found in the pull request guide