fix(FilterableMultiSelect): fix extra colon #19428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal fix for extra colon in hidden "Total items selected: : 0" message. Note that it already worked correctly when one or more items were selected. I don't like the way FilterableMultiSelect adds hidden text to the label, but aria-describedby is already being used to point to the (visible) helper text. Fixes carbon-design-system#19424.
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19428 +/- ##
=======================================
Coverage 84.87% 84.87%
=======================================
Files 372 372
Lines 14431 14431
Branches 4748 4717 -31
=======================================
Hits 12248 12248
+ Misses 2037 2036 -1
- Partials 146 147 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wkeese
force-pushed
the
FilterableMultiSelect-extra-colon
branch
from
26e938c to
8dc1a9f
Compare
Merged
via the queue into
carbon-design-system:main
with commit May 20, 2025
339dd74
53 of 54 checks passed
|
Hey there! v11.83.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19424.
Fix extra colon in hidden "Total items selected: : 0" message. Note that it already worked correctly when one or more items were selected.
Also get rid of duplicate (nested)
<span class="cds--visually-hidden">.I don't like the way FilterableMultiSelect adds hidden text to the label, but
aria-describedbyis already being used to point to the (visible) helper text.Changelog
Changed
Testing / Reviewing
Test on Storybook with JAWS.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide