-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(TreeView): treeview not passing props to treenode children #19417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TreeView): treeview not passing props to treenode children #19417
Conversation
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19417 +/- ##
==========================================
+ Coverage 84.87% 84.88% +0.01%
==========================================
Files 372 372
Lines 14431 14444 +13
Branches 4748 4751 +3
==========================================
+ Hits 12248 12261 +13
Misses 2037 2037
Partials 146 146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I have read the DCO document and I hereby sign the DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for doing this! The code looks great!
Just one thing, can you add some tests for lines [188–189] and [211–212], as they are not currently covered by our tests.
Also, a small suggestion for clarity (totally optional, both are functionally equivalent):
I would replace in TreeNode.tsx
file, lines [182–184]:
tabIndex: (!(node as ReactElement).props.disabled && -1) || null,
you could use:
tabIndex: node.props.disabled ? null : -1,
Please do not remove checklist items from the pr template. If some do not apply, just |
|
…/19136-treeview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
9b3655f
Hey there! v11.83.0 was just released that references this issue/PR. |
Closes #19136
Addressed the issue where TreeView doesn't pass props to TreeNode if TreeNode is wrapped by a component
Changelog
Changed
Testing / Reviewing
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesAddressed any impact on accessibility (a11y)More details can be found in the pull request guide