Skip to content

fix: remove invalid hook usage in wrapFocus utils #19407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

adamalston
Copy link
Contributor

@adamalston adamalston commented May 16, 2025

Closes #19386

Removed the invalid hook usage in the wrapFocus utils.

Changelog

Removed

  • Removed the invalid hook usage in the wrapFocus utils.

Testing / Reviewing

Check stories mentioned in #19386.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@adamalston adamalston changed the title fix: remove invalid hook usage in wrapFocus utils fix: remove invalid hook usage in wrapFocus utils May 16, 2025
Copy link

netlify bot commented May 16, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 35ab2bd
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/68275ad90b7bc70008315d24
😎 Deploy Preview https://deploy-preview-19407--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented May 16, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 35ab2bd
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/68275ad919349600083c2de4
😎 Deploy Preview https://deploy-preview-19407--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.85%. Comparing base (5a86693) to head (35ab2bd).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19407   +/-   ##
=======================================
  Coverage   84.85%   84.85%           
=======================================
  Files         371      371           
  Lines       14413    14413           
  Branches     4694     4716   +22     
=======================================
  Hits        12230    12230           
+ Misses       2037     2036    -1     
- Partials      146      147    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@heloiselui heloiselui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Adam!

@heloiselui heloiselui added this pull request to the merge queue May 21, 2025
Merged via the queue into carbon-design-system:main with commit 34964f5 May 21, 2025
53 of 54 checks passed
@adamalston adamalston deleted the 19386-wrap branch May 21, 2025 13:02
@carbon-automation
Copy link
Contributor

Hey there! v11.83.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid hook call on pressing Tab in ComposedModal with focus-wrap-without-sentinels
3 participants