-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(menu): prevent scroll when navigating with arrow keys #19392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(menu): prevent scroll when navigating with arrow keys #19392
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19392 +/- ##
=======================================
Coverage 84.85% 84.85%
=======================================
Files 371 371
Lines 14412 14412
Branches 4750 4694 -56
=======================================
Hits 12229 12229
- Misses 2036 2037 +1
+ Partials 147 146 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the ci checks needs some eyes
bdc774e
Closes #19389
While working on the new Combo Button component for web-components #19218, @thyhmdo was reviewing the PR and noticed there was an unexpected scroll when navigating menu items using the up/down arrow keys. I investigated and found that the same behavior also occurs in the Menu Button.
Changelog
New
Testing / Reviewing
Deploy Preview
>Menu Button
>Experimental Auto Align
PR Checklist
As the author of this PR, before marking ready for review, confirm you: