Skip to content

docs(Grid): update broken links #19368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

heloiselui
Copy link
Contributor

Closes #19359

Fix broken documentation links in Column.tsx and Grid overview page. The previous URLs under @see tags were returning 404 errors. These have been updated to point to the correct layout breakpoints documentation in the Carbon Design System site.

Changelog

Changed

  • Updated outdated @see links in Column.tsx to use the correct URLs: https://carbondesignsystem.com/elements/2x-grid/overview/#breakpoints
  • Updated corresponding links in Grid.mdx

Testing / Reviewing

To verify this PR:

  1. Open the changed file Column.tsx and verify that the updated links are working correctly
  2. Confirm that each link now points to a valid section on the Carbon Design System site (no more 404 errors)
  3. Navigate to Deploy Preview > Grid > Overview
  4. Check that the "2x Grid" and "Gutter" link directs to the correct page on the Carbon Design System site and no longer returns a 404 error.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • [N/A] Wrote passing tests that cover this change
  • [N/A] Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

Copy link

netlify bot commented May 13, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 3708f74
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/68233c5d22ddf5000841fc00
😎 Deploy Preview https://deploy-preview-19368--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 13, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 3708f74
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/68233c5da3506100080715a4
😎 Deploy Preview https://deploy-preview-19368--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.85%. Comparing base (97b21a8) to head (3708f74).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19368      +/-   ##
==========================================
+ Coverage   84.57%   84.85%   +0.28%     
==========================================
  Files         382      371      -11     
  Lines       14434    14412      -22     
  Branches     4712     4746      +34     
==========================================
+ Hits        12207    12229      +22     
+ Misses       2073     2037      -36     
+ Partials      154      146       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@riddhybansal riddhybansal added this pull request to the merge queue May 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 14, 2025
@heloiselui heloiselui added this pull request to the merge queue May 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 14, 2025
@heloiselui heloiselui added this pull request to the merge queue May 14, 2025
Merged via the queue into carbon-design-system:main with commit 372c77f May 14, 2025
37 checks passed
@heloiselui heloiselui deleted the 19359-broken-links branch May 14, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Broken Links in Grid/Column Component Documentation
3 participants