-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(ui-shell): set aria-current when current class styling added #19348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui-shell): set aria-current when current class styling added #19348
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19348 +/- ##
=======================================
Coverage 84.85% 84.85%
=======================================
Files 371 371
Lines 14413 14414 +1
Branches 4750 4751 +1
=======================================
+ Hits 12230 12231 +1
Misses 2036 2036
Partials 147 147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a057797
Hey there! v11.83.0 was just released that references this issue/PR. |
Closes #16885
Sets
aria-current="true"
when current class styling is added to a header menu item. A screen reader will now indicate the menu item that has different styling.Changelog
New
aria-current="true"
when rendering the menu item.Changed
aria-current="true"
isActive
prop to note this effectTesting / Reviewing
aria-current=true
for menu item with current class"cds--header__menu-item--current"
addedPR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide