Skip to content

test(list): unit tests and snapshots for ordered and unordered list #19310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented May 5, 2025

Closes #19303
Closes #19309

Unit tests for Web Components cds-ordered-list and cds-unordered-list

Changelog

New

  • added unit test for React UnorderedList to cover the expressive use case
  • added unit tests for cds-ordered-list and cds-unordered-list

Testing / Reviewing

Ci-checks pass

Copy link

netlify bot commented May 5, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit ad052c4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/68190521ccbda10008d1050e
😎 Deploy Preview https://deploy-preview-19310--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 5, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit ad052c4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/681905219145450008cee182
😎 Deploy Preview https://deploy-preview-19310--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (97343be) to head (ad052c4).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19310   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files         381      381           
  Lines       14436    14436           
  Branches     4766     4763    -3     
=======================================
  Hits        12209    12209           
- Misses       2072     2073    +1     
+ Partials      155      154    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@heloiselui heloiselui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam added this pull request to the merge queue May 6, 2025
Merged via the queue into carbon-design-system:main with commit 5d1b860 May 6, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[unordered-list]: update component unit tests and snapshots [ordered-list]: update component unit tests and snapshots
4 participants