Skip to content

fix(fileuploader): reinstate @-moz-document for firefox-specific styles #19305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented May 5, 2025

Reported on slack, the text overflow for the filename was not working in firefox

2025-05-05 at 11 21 37-Components  FileUploader - Drag And Drop Upload Container Example Application ⋅ Storybook-Firefox

This reinstates firefox-specific styles via the established "hack" @-moz-document url-prefix() that was originally present in #14660 and mistakenly removed in #17770

Changelog

Changed

  • updated fileuploader styles to properly target firefox

Testing / Reviewing

@tay1orjones tay1orjones requested review from a team as code owners May 5, 2025 16:39
@tay1orjones tay1orjones self-assigned this May 5, 2025
@tay1orjones tay1orjones moved this to 🚦 In Review in Design System May 5, 2025
Copy link

netlify bot commented May 5, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 513c147
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6818e9cffb6ab50008830eba
😎 Deploy Preview https://deploy-preview-19305--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 5, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 513c147
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6818e9cf135b05000834aa23
😎 Deploy Preview https://deploy-preview-19305--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 5, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 3e82506
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6818eb29c107cb00088a20fe
😎 Deploy Preview https://deploy-preview-19305--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 5, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 3e82506
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6818eb2947c4960008f45cad
😎 Deploy Preview https://deploy-preview-19305--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (cd03c8a) to head (3e82506).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19305   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files         381      381           
  Lines       14436    14436           
  Branches     4711     4766   +55     
=======================================
  Hits        12209    12209           
+ Misses       2073     2072    -1     
- Partials      154      155    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kennylam kennylam added this pull request to the merge queue May 7, 2025
Merged via the queue into carbon-design-system:main with commit a98d8d0 May 7, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System May 7, 2025
@carbon-automation
Copy link
Contributor

Hey there! v11.82.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants