Skip to content

Fix WC data-table ai label column cells #19293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devadula-nandan
Copy link
Contributor

@devadula-nandan devadula-nandan commented May 5, 2025

Contributes to #17739

renames slug to ai-label in a css selector, bringing back the missing gradient styles in column ai label stories

Changelog

Changed
changed a css selector from slug to ai-label

Testing / Reviewing

visually through storybook, in all column ai label variants

before after
Screenshot 2025-05-05 at 3 25 02 PM Screenshot 2025-05-05 at 3 25 13 PM

Copy link

netlify bot commented May 5, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit f2bb412
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/68188a49d37e260008dc2c61
😎 Deploy Preview https://deploy-preview-19293--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devadula-nandan devadula-nandan marked this pull request as ready for review May 5, 2025 09:59
@devadula-nandan devadula-nandan requested review from a team as code owners May 5, 2025 09:59
Copy link

netlify bot commented May 5, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f2bb412
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/68188a49b51d900008b43d41
😎 Deploy Preview https://deploy-preview-19293--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devadula-nandan devadula-nandan changed the title fix: ai label column cells Fix WC data-table ai label column cells May 5, 2025
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (52445b5) to head (f2bb412).
Report is 65 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19293   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files         382      382           
  Lines       14434    14434           
  Branches     4712     4712           
=======================================
  Hits        12207    12207           
  Misses       2073     2073           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@heloiselui heloiselui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@heloiselui heloiselui added this pull request to the merge queue May 21, 2025
Merged via the queue into carbon-design-system:main with commit 40a5f25 May 21, 2025
42 of 54 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.83.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants