High Contrast Mode style fix for PasswordInput #19291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
mariyageorge01
force-pushed
the
cds-19183-hcm
branch
from
e75cb81 to
e2e9d39
Compare
heloiselui
reviewed
May 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19291 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 380 380
Lines 14471 14471
Branches 4771 4771
=======================================
Hits 12242 12242
Misses 2074 2074
Partials 155 155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mariyageorge01
force-pushed
the
cds-19183-hcm
branch
from
e2e9d39 to
238a569
Compare
|
@heloiselui Thank you for reviewing my PR 🙂. I have resolved the merge conflicts 🙂. |
|
Percy failed. But I don't have the access to see the error. 
|
heloiselui
approved these changes
May 6, 2025
kennylam
approved these changes
May 6, 2025
kennylam
added
a11y: high contrast mode
- fixed hcm style for PasswordInput Contributes-to: carbon-design-system#19183 Signed-off-by: Mariya George [email protected]
mariyageorge01
force-pushed
the
cds-19183-hcm
branch
from
865bf26 to
8ea200b
Compare
Merged
via the queue into
carbon-design-system:main
with commit May 6, 2025
eacd2b7
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ##19183
This PR fixes a style issue when Windows High Contrast Mode is enabled in PasswordInput.
Changelog
New
Changed
Removed
Testing / Reviewing
Pull the branch locally and check that PasswordInput works well in HCM