Skip to content

fix(table-header): decorator wrapper #19283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented May 1, 2025

Closes #18490

Current (extra space for decorator wrapper but no decorator is being used):
Screenshot 2025-05-01 at 1 13 41 PM

New Changes (only have space when decorator is being used):
Screenshot 2025-05-01 at 1 15 25 PM

Changelog

Changed

  • the data table header needed styles to hide the decorator from being visual when there was no decorator there

Testing / Reviewing

data table AI story: confirm AI Label is still there
data table sorting story: when hovering the sorting icons should not have any extra space next to them. the decorator class should not be present

Copy link

netlify bot commented May 1, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit f9933ff
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/681a40208bf8220008cafe1c
😎 Deploy Preview https://deploy-preview-19283--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 1, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit f9933ff
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/681a4020cf081f00083eca8e
😎 Deploy Preview https://deploy-preview-19283--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.59%. Comparing base (eacd2b7) to head (f9933ff).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19283   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         380      380           
  Lines       14471    14471           
  Branches     4768     4716   -52     
=======================================
  Hits        12242    12242           
  Misses       2075     2075           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review May 1, 2025 22:11
@ariellalgilmore ariellalgilmore requested review from a team as code owners May 1, 2025 22:11
Copy link
Contributor

@heloiselui heloiselui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heloiselui heloiselui added this pull request to the merge queue May 7, 2025
Merged via the queue into carbon-design-system:main with commit bcb4931 May 7, 2025
37 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.82.0 was just released that references this issue/PR.

@ariellalgilmore ariellalgilmore deleted the fix/data-table-ai-header branch May 8, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Extra decorator <div> introduced to table header in V11.73.0 affected our table header layouts
3 participants