-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(table-header): decorator wrapper #19283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table-header): decorator wrapper #19283
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19283 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 380 380
Lines 14471 14471
Branches 4768 4716 -52
=======================================
Hits 12242 12242
Misses 2075 2075
Partials 154 154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bcb4931
Hey there! v11.82.0 was just released that references this issue/PR. |
Closes #18490
Current (extra space for decorator wrapper but no decorator is being used):

New Changes (only have space when decorator is being used):

Changelog
Changed
Testing / Reviewing
data table AI story: confirm AI Label is still there
data table sorting story: when hovering the sorting icons should not have any extra space next to them. the decorator class should not be present