-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(ListBox): rename colliding symbols and fix prop types #19232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19232 +/- ##
=======================================
Coverage 84.41% 84.41%
=======================================
Files 385 385
Lines 14563 14563
Branches 4806 4775 -31
=======================================
Hits 12294 12294
+ Misses 2110 2109 -1
- Partials 159 160 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
c455dd1
No issue.
Rename colliding
ListBox
symbols and fixed prop types.Changelog
New
FilterableMultiSelect
.Changed
ListBox
symbols.ListBox
prop types.Testing / Reviewing
yarn test packages/react