Skip to content

refactor: rewrite sorting tools in typescript and add tests #19225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

adamalston
Copy link
Contributor

No issue.

Rewrote sorting in TypeScript and added tests

Changelog

New

  • Added sorting tests.

Changed

  • Rewrote sorting in TypeScript.

Testing / Reviewing

yarn test packages/react

Copy link

netlify bot commented Apr 23, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 0b4e2d9
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/68090cacbfad3500089ce555
😎 Deploy Preview https://deploy-preview-19225--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 23, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0b4e2d9
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/68090cacd7bcda000830d242
😎 Deploy Preview https://deploy-preview-19225--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (9362a53) to head (0b4e2d9).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19225      +/-   ##
==========================================
+ Coverage   84.41%   84.45%   +0.03%     
==========================================
  Files         385      384       -1     
  Lines       14563    14566       +3     
  Branches     4809     4783      -26     
==========================================
+ Hits        12294    12302       +8     
+ Misses       2109     2105       -4     
+ Partials      160      159       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamalston adamalston marked this pull request as ready for review April 23, 2025 16:14
@adamalston adamalston requested review from a team as code owners April 23, 2025 16:14
@adamalston adamalston changed the title refactor: rewrite sorting in typescript and add tests refactor: rewrite sorting tools in typescript and add tests Apr 24, 2025
Copy link
Contributor

@heloiselui heloiselui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@annawen1 annawen1 added this pull request to the merge queue Apr 28, 2025
Merged via the queue into carbon-design-system:main with commit 584f7e7 Apr 28, 2025
53 of 54 checks passed
@adamalston adamalston deleted the n/a-sorting branch April 28, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants