fix: missing underline when using spaceEqually for ProgressIndicator #19213
Conversation
fix spaceEqually causing wrong behavior within the ProgressIndicator component
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
recheck |
|
Hey @murito , could you please change the title to describe the fix in the PR?? |
murito
changed the title
There was a problem hiding this comment.
Nice fix! Thanks for that, just a small suggestion, you could use $spacing-01 and -$spacing-01 instead of hardcoded 1px values, following the layout Sass guidelines.
| @@ -80,6 +80,8 @@ $progress-indicator-bar-width: 1px inset transparent !default; | |||
|
|
|||
| .#{$prefix}--progress--space-equal .#{$prefix}--progress-text { | |||
| overflow: hidden; | |||
| padding: 1px; | |||
There was a problem hiding this comment.
| padding: 1px; | |
| padding: $spacing-01; |
| @@ -80,6 +80,8 @@ $progress-indicator-bar-width: 1px inset transparent !default; | |||
|
|
|||
| .#{$prefix}--progress--space-equal .#{$prefix}--progress-text { | |||
| overflow: hidden; | |||
| padding: 1px; | |||
| margin: -1px; | |||
There was a problem hiding this comment.
| margin: -1px; | |
| margin: -$spacing-01; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19213 +/- ##
=======================================
Coverage 84.41% 84.41%
=======================================
Files 385 385
Lines 14563 14563
Branches 4806 4806
=======================================
Hits 12294 12294
+ Misses 2110 2109 -1
- Partials 159 160 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1dcc965
…arbon-design-system#19213) * fix: updating style rule to fix a component behavior fix spaceEqually causing wrong behavior within the ProgressIndicator component * refactor: change to css variables instead of hardcoded values
Closes #19164
Resolve the issue that prevented adding an underline when the spaceEqually attribute is applied to the ProgressIndicator
Changelog
Changed
Testing / Reviewing
Import the ProgressIndicator into a React component and add the spaceEqually attribute. When hovering over the items, they should display the underline.