Skip to content

chore(docs): update storybook tabs to time-picker #19194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ariellalgilmore
Copy link
Member

This updates the Storybook overview docs for time-picker, tile, textarea, text-input, tabs, and tags web components to match their React counterparts.

The stories should match React versions as closely as possible, excepting framework-specific documentation. Note that there will be differences in documentation/API as not all of these components have full parity with React.

Changelog

Changed

  • update Storybook docs formatting to match React versions
  • add Canvas elements to story overviews for examples and source code
  • add missing @element when needed so attributes would render in mdx
  • react had wrong component listed in the mdx file for textarea and textinput

Testing / Reviewing

  • updated stories should match React versions as closely as possible
  • make sure breadcrumb and table of content links go where they're supposed to
  • ensure all inline examples work as expected and source code is correct

@ariellalgilmore ariellalgilmore marked this pull request as ready for review April 21, 2025 18:20
@ariellalgilmore ariellalgilmore requested review from a team as code owners April 21, 2025 18:20
Copy link

netlify bot commented Apr 21, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c75844b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6807d93817f4be00084071cb
😎 Deploy Preview https://deploy-preview-19194--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 21, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit c75844b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6807d93813e0ee0008fb13c7
😎 Deploy Preview https://deploy-preview-19194--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (d123efe) to head (c75844b).
Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19194   +/-   ##
=======================================
  Coverage   84.37%   84.37%           
=======================================
  Files         388      385    -3     
  Lines       14547    14539    -8     
  Branches     4753     4802   +49     
=======================================
- Hits        12274    12268    -6     
+ Misses       2114     2112    -2     
  Partials      159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@annawen1 annawen1 added this pull request to the merge queue Apr 22, 2025
Merged via the queue into carbon-design-system:main with commit cf4a824 Apr 22, 2025
37 checks passed
@annawen1 annawen1 deleted the chore/docs-update-time-picker-to-tabs branch April 22, 2025 20:27
@carbon-automation
Copy link
Contributor

Hey there! v11.81.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants