feat: add prop-types to OverflowMenu
#19171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19171 +/- ##
==========================================
+ Coverage 84.38% 84.40% +0.01%
==========================================
Files 387 387
Lines 14547 14547
Branches 4751 4751
==========================================
+ Hits 12276 12278 +2
+ Misses 2112 2110 -2
Partials 159 159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
annawen1
approved these changes
Apr 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Apr 22, 2025
73209f6
37 checks passed
|
Hey there! v11.81.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #19144
Added prop-types to
OverflowMenu.Changelog
New
OverflowMenu.Removed
createClassWrapperusage forOverflowMenu. This usage probably should have been deleted when refactor(OverflowMenu): convert to functional component and add types #18690 was addressed.imports fromOverflowMenuinpackages/react/src/components/OverflowMenu/index.tsx.Testing / Reviewing
yarn test packages/react