Skip to content

fix(Modal): prevent double submit on primary button enter key #19151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

adamalston
Copy link
Contributor

@adamalston adamalston commented Apr 16, 2025

Closes #10882

Prevented double submit on Modal primary button Enter key.

Changelog

Changed

  • Prevented double submit on Modal primary button Enter key.

Testing / Reviewing

yarn test packages/react

Copy link

netlify bot commented Apr 16, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7fccf75
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67ffc3408115180008dec218
😎 Deploy Preview https://deploy-preview-19151--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 16, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 7fccf75
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67ffc3409e24d50008a48f05
😎 Deploy Preview https://deploy-preview-19151--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (48ba19d) to head (7fccf75).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19151   +/-   ##
=======================================
  Coverage   84.25%   84.26%           
=======================================
  Files         388      388           
  Lines       14521    14524    +3     
  Branches     4787     4736   -51     
=======================================
+ Hits        12235    12238    +3     
- Misses       2126     2127    +1     
+ Partials      160      159    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamalston adamalston marked this pull request as ready for review April 16, 2025 15:14
@adamalston adamalston requested review from a team as code owners April 16, 2025 15:14
@heloiselui heloiselui added this pull request to the merge queue Apr 17, 2025
Merged via the queue into carbon-design-system:main with commit 7eee3a8 Apr 17, 2025
53 of 54 checks passed
@adamalston adamalston deleted the 10882-modal branch April 17, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Modal with shouldSubmitOnEnter double submits if keyboard used on submit button
3 participants