-
Notifications
You must be signed in to change notification settings - Fork 1.9k
refactor: convert HeaderMenu
to functional component
#19128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert HeaderMenu
to functional component
#19128
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19128 +/- ##
==========================================
- Coverage 84.87% 84.86% -0.01%
==========================================
Files 372 372
Lines 14430 14421 -9
Branches 4750 4694 -56
==========================================
- Hits 12247 12238 -9
- Misses 2036 2037 +1
+ Partials 147 146 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
45b27c2
Closes #19126
Partially addresses #19144
Converted
HeaderMenu
to a functional component.Changelog
New
HeaderMenu
.Changed
HeaderMenu
to a functional component.Testing / Reviewing
yarn test packages/react