Skip to content

refactor: convert HeaderMenu to functional component #19128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2025

Conversation

adamalston
Copy link
Contributor

@adamalston adamalston commented Apr 14, 2025

Closes #19126
Partially addresses #19144

Converted HeaderMenu to a functional component.

Changelog

New

  • Added missing types to HeaderMenu.

Changed

  • Converted HeaderMenu to a functional component.

Testing / Reviewing

yarn test packages/react

Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 01679e4
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/682cb438aee23b0008fa93c8
😎 Deploy Preview https://deploy-preview-19128--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 01679e4
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/682cb438d8790c0008fd1b44
😎 Deploy Preview https://deploy-preview-19128--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 92.15686% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.86%. Comparing base (577e609) to head (01679e4).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/react/src/components/UIShell/HeaderMenu.tsx 92.15% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19128      +/-   ##
==========================================
- Coverage   84.87%   84.86%   -0.01%     
==========================================
  Files         372      372              
  Lines       14430    14421       -9     
  Branches     4750     4694      -56     
==========================================
- Hits        12247    12238       -9     
- Misses       2036     2037       +1     
+ Partials      147      146       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamalston adamalston marked this pull request as ready for review April 14, 2025 15:02
@adamalston adamalston requested review from a team as code owners April 14, 2025 15:02
Copy link
Contributor

@Gururajj77 Gururajj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tay1orjones tay1orjones added this pull request to the merge queue May 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2025
@heloiselui heloiselui added this pull request to the merge queue May 22, 2025
Merged via the queue into carbon-design-system:main with commit 45b27c2 May 22, 2025
37 checks passed
@adamalston adamalston deleted the 19126-header-menu branch May 22, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert HeaderMenu to a functional component
4 participants