Skip to content

refactor: port setupGetInstanceId to typescript #19104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025

Conversation

adamalston
Copy link
Contributor

Closes #19102

Ported setupGetInstanceId to TypeScript.

Changelog

Changed

  • Ported setupGetInstanceId to TypeScript.

Testing / Reviewing

yarn test packages/react

Copy link

netlify bot commented Apr 11, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 92b4928
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67f90dce15edaa0007fcd01a
😎 Deploy Preview https://deploy-preview-19104--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 11, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 92b4928
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67f90dcebdb87d000891967d
😎 Deploy Preview https://deploy-preview-19104--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.98%. Comparing base (ac62dbb) to head (92b4928).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19104      +/-   ##
==========================================
- Coverage   84.98%   84.98%   -0.01%     
==========================================
  Files         390      389       -1     
  Lines       14487    14483       -4     
  Branches     4719     4771      +52     
==========================================
- Hits        12312    12308       -4     
  Misses       2027     2027              
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamalston adamalston marked this pull request as ready for review April 11, 2025 13:01
@adamalston adamalston requested review from a team as code owners April 11, 2025 13:01
Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennylam kennylam added this pull request to the merge queue Apr 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2025
@kennylam kennylam added this pull request to the merge queue Apr 19, 2025
Merged via the queue into carbon-design-system:main with commit e243272 Apr 19, 2025
53 of 54 checks passed
@adamalston adamalston deleted the 19102-instance-id branch April 19, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port setupGetInstanceId to TypeScript
4 participants