Skip to content

fix(checkbox): add id to checkbox label #19096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

annawen1
Copy link
Member

Closes #19095

The checkbox recently had an id attribute added as it was previously hardcoded, the id was passed into the checkbox input element. The corresponding label element also has to be updated to take the same id attribute in order for the checkbox status to update.

Changelog

Changed

  • add label's for attribute to take the id passed from user
  • set default value for id to "checkbox"

Testing / Reviewing

Go to WC deploy preview and confirm you are able to check / uncheck the checkbox

@annawen1 annawen1 requested review from a team as code owners April 10, 2025 16:16
Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 44b54ec
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67f7eed03dc0fa00081e13b7
😎 Deploy Preview https://deploy-preview-19096--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 44b54ec
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67f7eed0947bf800075468b3
😎 Deploy Preview https://deploy-preview-19096--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@annawen1 annawen1 enabled auto-merge April 10, 2025 16:26
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.96%. Comparing base (26b2544) to head (44b54ec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19096   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files         391      391           
  Lines       14490    14490           
  Branches     4773     4776    +3     
=======================================
  Hits        12312    12312           
  Misses       2029     2029           
  Partials      149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@annawen1 annawen1 added this pull request to the merge queue Apr 10, 2025
Merged via the queue into carbon-design-system:main with commit 301bb5a Apr 10, 2025
37 checks passed
@annawen1 annawen1 deleted the fix/wc-checkbox-id branch April 10, 2025 17:04
annawen1 added a commit to annawen1/carbon that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Checkbox not working
3 participants