Skip to content

fix: adds backward compatibility for innerRefs in OverflowMenu #19086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

2nikhiltom
Copy link
Contributor

Closes #19046

adds backward compatibility for innerRef

Changelog

New

innerRef is also merged if passed
mergeRefs(triggerRef, innerRef, ref)

Added test case against the functionality

Changed

@deprecated Use the standard React ref instead.
marked innerRef as deprecated

Removed

  • {{removed thing}}

Testing / Reviewing

CI checks should pass
yarn test packages/react/src/components/OverflowMenu

@2nikhiltom 2nikhiltom requested review from a team as code owners April 10, 2025 09:14
@2nikhiltom 2nikhiltom changed the title fix: adds backward compatibility for innerRefs fix: adds backward compatibility for innerRefs in OverflowMenu Apr 10, 2025
Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit aef0e73
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67f7b4d1d9ac0b00085e53b2
😎 Deploy Preview https://deploy-preview-19086--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit aef0e73
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67f7b4d13a81da0008ada67f
😎 Deploy Preview https://deploy-preview-19086--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (517562c) to head (aef0e73).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19086   +/-   ##
=======================================
  Coverage   84.96%   84.97%           
=======================================
  Files         391      391           
  Lines       14490    14493    +3     
  Branches     4776     4779    +3     
=======================================
+ Hits        12312    12315    +3     
  Misses       2029     2029           
  Partials      149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ariellalgilmore ariellalgilmore added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit 4e75061 Apr 10, 2025
37 checks passed
@ariellalgilmore ariellalgilmore deleted the innerRef-overflow-fix branch April 10, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OverflowMenu innerRef no longer available
3 participants