Skip to content

refactor: rewrite wrapFocus utils in typescript #18913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 29, 2025

Conversation

adamalston
Copy link
Contributor

Closes #18911

Rewrote the wrapFocus utilities in TypreScript.

Changelog

New

Changed

  • Rewrote the wrapFocus utilities in TypreScript.
  • Updated types in usages of the wrapFocus utilities.

Testing / Reviewing

yarn test packages/react

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d9896d8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/680ab9f84b9cee00089c69e3
😎 Deploy Preview https://deploy-preview-18913--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit d9896d8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/680ab9f882047f0008cdc5ce
😎 Deploy Preview https://deploy-preview-18913--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 33f583c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67e2aee890362a0008b9f351
😎 Deploy Preview https://deploy-preview-18913--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.46%. Comparing base (84d0e93) to head (d9896d8).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
packages/react/src/internal/FloatingMenu.tsx 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18913      +/-   ##
==========================================
+ Coverage   84.41%   84.46%   +0.04%     
==========================================
  Files         385      384       -1     
  Lines       14563    14528      -35     
  Branches     4806     4740      -66     
==========================================
- Hits        12294    12271      -23     
+ Misses       2110     2101       -9     
+ Partials      159      156       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamalston adamalston marked this pull request as ready for review March 25, 2025 13:48
@adamalston adamalston requested review from a team as code owners March 25, 2025 13:48
@adamalston
Copy link
Contributor Author

adamalston commented Apr 18, 2025

Looks like https://github.com/carbon-design-system/carbon/actions/runs/14541187128/job/40799369554?pr=18913 needs to be restarted.

@heloiselui heloiselui added this pull request to the merge queue Apr 29, 2025
Merged via the queue into carbon-design-system:main with commit c5312a3 Apr 29, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite wrapFocus utils in TypeScript
3 participants