Skip to content

fix: makes tooltips visible in fileuploaderItem #18910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025
Merged

Conversation

2nikhiltom
Copy link
Contributor

@2nikhiltom 2nikhiltom commented Mar 25, 2025

Closes #18477

Updates FileUploaderItem storybook example to display tooltip

image

Changelog

Changed

Made label text really long for FileUploaderItem storybook example

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit bde4850
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67f50e7b0d3e4a000873230b
😎 Deploy Preview https://deploy-preview-18910--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b048494
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67e3e85f29720d00083d5834
😎 Deploy Preview https://deploy-preview-18910--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit bde4850
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67f50e7b0ae2c200087facbd
😎 Deploy Preview https://deploy-preview-18910--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.98%. Comparing base (00d8b2f) to head (bde4850).
Report is 50 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18910   +/-   ##
=======================================
  Coverage   84.98%   84.98%           
=======================================
  Files         394      394           
  Lines       14534    14534           
  Branches     4735     4790   +55     
=======================================
  Hits        12351    12351           
+ Misses       2035     2034    -1     
- Partials      148      149    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2nikhiltom 2nikhiltom marked this pull request as ready for review March 26, 2025 12:07
@2nikhiltom 2nikhiltom requested review from a team as code owners March 26, 2025 12:07
@2nikhiltom 2nikhiltom requested review from riddhybansal, annawen1 and thyhmdo and removed request for riddhybansal March 26, 2025 12:07
@2nikhiltom 2nikhiltom changed the title fix: makes tooltips visible fix: makes tooltips visible in fileuploaderItem Mar 26, 2025
@kennylam kennylam added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 5f9f352 Apr 16, 2025
37 checks passed
@kennylam kennylam deleted the 18477_visible_tooltip branch April 16, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tooltip] Make tooltip visible in certain components
4 participants