Skip to content

chore(deps): update dependency nanoid to v5 #18596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

chore(deps): update dependency nanoid to v5 #18596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19d20f6
chore(deps): update dependency nanoid to v5
renovate[bot] May 5, 2025
2dbb57b
Merge branch 'main' into renovate/nanoid-5.x
preetibansalui May 8, 2025
50cd14a
fix: test case
preetibansalui May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .yarn/cache/nanoid-npm-5.1.5-79b61a9d37-6de2d006b5.zip
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module.exports = {
],
coveragePathIgnorePatterns: ['packages/web-components/*'],
testPathIgnorePatterns: ['packages/web-components/*'],
transformIgnorePatterns: ['<rootDir>/node_modules/(?!lodash-es)'],
transformIgnorePatterns: ['<rootDir>/node_modules/(?!lodash-es|nanoid)'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the moduleNameMapper on the next line still needed?

https://github.com/carbon-design-system/carbon/pull/18596/files#diff-1e058ca1442e46581b13571fb8d261f9e1f5657e26c96634d4c1072f0f0347f1R24-R32

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we still need this because moduleNameMapper helps resolve it in the CJS setup, while transformIgnorePatterns only controls which modules are transformed, not how they're resolved.

moduleNameMapper: {
// This is a temporary workaround from moving to Jest v28. In this update,
// certain dependencies are only providing ESM through exports and so we use
Expand Down
2 changes: 1 addition & 1 deletion packages/upgrade/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"lodash.clonedeep": "^4.5.0",
"lodash.merge": "^4.6.2",
"memfs": "^4.0.0",
"nanoid": "^3.1.30",
"nanoid": "^5.0.0",
"npm-which": "^3.0.1",
"rimraf": "^6.0.0",
"semver": "^7.3.5",
Expand Down
13 changes: 11 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2164,7 +2164,7 @@ __metadata:
lodash.clonedeep: "npm:^4.5.0"
lodash.merge: "npm:^4.6.2"
memfs: "npm:^4.0.0"
nanoid: "npm:^3.1.30"
nanoid: "npm:^5.0.0"
npm-which: "npm:^3.0.1"
rimraf: "npm:^6.0.0"
semver: "npm:^7.3.5"
Expand Down Expand Up @@ -20984,7 +20984,7 @@ __metadata:
languageName: node
linkType: hard

"nanoid@npm:^3.1.25, nanoid@npm:^3.1.30, nanoid@npm:^3.3.6, nanoid@npm:^3.3.8":
"nanoid@npm:^3.1.25, nanoid@npm:^3.3.6, nanoid@npm:^3.3.8":
version: 3.3.8
resolution: "nanoid@npm:3.3.8"
bin:
Expand All @@ -20993,6 +20993,15 @@ __metadata:
languageName: node
linkType: hard

"nanoid@npm:^5.0.0":
version: 5.1.5
resolution: "nanoid@npm:5.1.5"
bin:
nanoid: bin/nanoid.js
checksum: 10/6de2d006b51c983be385ef7ee285f7f2a57bd96f8c0ca881c4111461644bd81fafc2544f8e07cb834ca0f3e0f3f676c1fe78052183f008b0809efe6e273119f5
languageName: node
linkType: hard

"natural-compare-lite@npm:^1.4.0":
version: 1.4.0
resolution: "natural-compare-lite@npm:1.4.0"
Expand Down
Loading