Skip to content

fix: overflow menu with 3 level nested options display issue #18462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

preetibansalui
Copy link
Contributor

Closes #18320

Overflow menu with 3 level of nested values had display issue

Changelog

Changed

Apply css styles

Testing / Reviewing

  1. Go to Storybook > OverflowMenu > Feature Flag > Nested
  2. Hover on overflowmenu upto 4 levels, It should display correctly

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 9c39b51
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6799f41ba7121c0008b65383
😎 Deploy Preview https://deploy-preview-18462--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9c39b51
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6799f41b927add0008523318
😎 Deploy Preview https://deploy-preview-18462--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9c39b51
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6799f41be5349000080dbeb1
😎 Deploy Preview https://deploy-preview-18462--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (8acd725) to head (9c39b51).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18462      +/-   ##
==========================================
- Coverage   84.16%   84.16%   -0.01%     
==========================================
  Files         408      408              
  Lines       14446    14449       +3     
  Branches     4664     4646      -18     
==========================================
+ Hits        12159    12161       +2     
- Misses       2122     2124       +2     
+ Partials      165      164       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennylam kennylam added this pull request to the merge queue Jan 31, 2025
Merged via the queue into carbon-design-system:main with commit d975d04 Jan 31, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: overflowmenu nested with 3 level of menus has bad display
4 participants