Skip to content

feat(inline-loading): parity work #18437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

amal-k-joy
Copy link
Contributor

@amal-k-joy amal-k-joy commented Jan 27, 2025

Closes #18375

Fixing parities in InlineLoading component between react and webcomponent. Below props in webcomponents was not matching with what we have in react. So added new props and deprecating the respective ones to match with React

iconDescription ==> assistiveText

  • Created a UX Example story as in react
  • Added missing controls to storybook
  • Removed playground story

Testing / Reviewing

Can be verified in storybook controls

@amal-k-joy amal-k-joy requested a review from a team as a code owner January 27, 2025 10:22
@amal-k-joy amal-k-joy marked this pull request as draft January 27, 2025 10:22
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c953379
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67f4c1d263e9f40008f0f440
😎 Deploy Preview https://deploy-preview-18437--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c953379
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67f4c1d2c773500008a74b85
😎 Deploy Preview https://deploy-preview-18437--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c953379
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67f4c1d20fb6e80008718095
😎 Deploy Preview https://deploy-preview-18437--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.93%. Comparing base (e7abcd6) to head (c953379).
Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18437      +/-   ##
==========================================
+ Coverage   84.86%   84.93%   +0.07%     
==========================================
  Files         400      395       -5     
  Lines       14531    14541      +10     
  Branches     4732     4735       +3     
==========================================
+ Hits        12332    12351      +19     
+ Misses       2051     2042       -9     
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amal-k-joy amal-k-joy marked this pull request as ready for review February 26, 2025 11:32
@amal-k-joy amal-k-joy requested review from a team as code owners February 26, 2025 11:32
@annawen1 annawen1 changed the title Parity inline loading18375 feat(inline-loading): parity work Mar 20, 2025
@amal-k-joy amal-k-joy requested a review from annawen1 March 24, 2025 11:23
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amal-k-joy

Default story
For the status: Instead of saying "Failed", it should just say "Error" to match React.

Screenshot 2025-04-02 at 1 29 20 PM

Ux Example story
When you click the "Submit" button, it turns to the loading spinner and says “Submitting” which is good and is what React does. However once the loading is done, a checkmark appears and the message should say “Submitted!” to match React, but right now the message does not change.

Apr-02-2025 13-27-44

@amal-k-joy
Copy link
Contributor Author

@amal-k-joy

Default story For the status: Instead of saying "Failed", it should just say "Error" to match React.

Screenshot 2025-04-02 at 1 29 20 PM **Ux Example story** When you click the "Submit" button, it turns to the loading spinner and says “Submitting” which is good and is what React does. However once the loading is done, a checkmark appears and the message should say “Submitted!” to match React, but right now the message does not change.

Apr-02-2025 13-27-44 Apr-02-2025 13-27-44

@laurenmrice ,
Thanks for highlighting . I have updated the code.

@amal-k-joy amal-k-joy requested a review from laurenmrice April 8, 2025 06:28
@preetibansalui preetibansalui added this pull request to the merge queue Apr 9, 2025
Merged via the queue into carbon-design-system:main with commit dae0aa2 Apr 9, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React|WC Parity: Inline-loading
5 participants