-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(inline-loading): parity work #18437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inline-loading): parity work #18437
Conversation
…o parityLoading17925
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18437 +/- ##
==========================================
+ Coverage 84.86% 84.93% +0.07%
==========================================
Files 400 395 -5
Lines 14531 14541 +10
Branches 4732 4735 +3
==========================================
+ Hits 12332 12351 +19
+ Misses 2051 2042 -9
Partials 148 148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
packages/web-components/src/components/inline-loading/inline-loading.stories.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/inline-loading/inline-loading.ts
Outdated
Show resolved
Hide resolved
…oading.ts Co-authored-by: Anna Wen <[email protected]>
…oading.ts Co-authored-by: Anna Wen <[email protected]>
packages/web-components/src/components/inline-loading/inline-loading.stories.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/inline-loading/inline-loading.stories.ts
Outdated
Show resolved
Hide resolved
…oading.stories.ts Co-authored-by: Anna Wen <[email protected]>
…oading.stories.ts Co-authored-by: Anna Wen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default story
For the status: Instead of saying "Failed", it should just say "Error" to match React.

Ux Example story
When you click the "Submit" button, it turns to the loading spinner and says “Submitting” which is good and is what React does. However once the loading is done, a checkmark appears and the message should say “Submitted!” to match React, but right now the message does not change.
@laurenmrice , |
dae0aa2
Closes #18375
Fixing parities in InlineLoading component between react and webcomponent. Below props in webcomponents was not matching with what we have in react. So added new props and deprecating the respective ones to match with React
iconDescription ==> assistiveText
Testing / Reviewing
Can be verified in storybook controls