Skip to content

fix: type definition for onSelect prop in TreeView component #17153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jacobodeharo
Copy link
Contributor

Closes #17151

@jacobodeharo jacobodeharo requested a review from a team as a code owner August 13, 2024 10:29
Copy link
Contributor

github-actions bot commented Aug 13, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@jacobodeharo
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7b4fd28
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66bb357dd531a300080c7272
😎 Deploy Preview https://deploy-preview-17153--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 085b3f8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66d98f2086ba2600082c4e41
😎 Deploy Preview https://deploy-preview-17153--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari
Copy link
Contributor

guidari commented Aug 13, 2024

Hey @jacobodeharo I see that he CI is failing. Try to run yarn test -u to see if it fixes some of those issues.

@jacobodeharo jacobodeharo force-pushed the fix/treeview_onselect_type_definition branch from 162da3e to b30e403 Compare August 13, 2024 18:47
@jacobodeharo
Copy link
Contributor Author

jacobodeharo commented Aug 13, 2024

Hey @jacobodeharo I see that he CI is failing. Try to run yarn test -u to see if it fixes some of those issues.

@guidari Done!

Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 085b3f8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66d98f2016426c0008be46be
😎 Deploy Preview https://deploy-preview-17153--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Thanks!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

auto-merge was automatically disabled September 5, 2024 10:59

Head branch was pushed to by a user without write access

@jacobodeharo jacobodeharo force-pushed the fix/treeview_onselect_type_definition branch from 13d2672 to 085b3f8 Compare September 5, 2024 10:59
@guidari guidari enabled auto-merge September 5, 2024 12:31
@guidari guidari added this pull request to the merge queue Sep 5, 2024
Merged via the queue into carbon-design-system:main with commit 37a1236 Sep 5, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeScript TreeView onSelect event handler seems to have wrong type definition
3 participants