fix(PasswordInput): tooltip issue in show password label or hide password label

[preetibansalui]

Closes #16924

fixed broken tooltip if label is blank and added a console warning if label is blank.

New

added a console warning if showPasswordLabel or hidePasswordLabel is blank.

[netlify]

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	a86f7c5
🔍 Latest deploy log	https://app.netlify.com/sites/v11-carbon-react/deploys/66b07b9dc69a1900086b2345
😎 Deploy Preview	https://deploy-preview-17103--v11-carbon-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	a86f7c5
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/66b07b9d04a36a0008dd2160
😎 Deploy Preview	https://deploy-preview-17103--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[2nikhiltom]

Hey @preetibansalui

Just a question : Should the tooltip be rendered on UI if the string is empty ? I see warning is console but the tooltip renders with no content.

Im curious of useCase where consumers would want to pass an empty string for hidePasswordLabel/ ShowPasswordLabel.
and Incase they do want an empty string, should we completely remove the tooltip itself ?

[Kritvi-bhatia17]

Looks good to me from design perspective! 🎉

[preetibansalui]

Hey @preetibansalui

Just a question : Should the tooltip be rendered on UI if the string is empty ? I see warning is console but the tooltip renders with no content.

Im curious of useCase where consumers would want to pass an empty string for hidePasswordLabel/ ShowPasswordLabel. and Incase they do want an empty string, should we completely remove the tooltip itself ?

Hi @2nikhiltom, you've raised a valid point.

1. While there's no purpose in providing an empty string for the tooltip, users are still able to enter any value in the label field. Therefore, we need to handle for the case of a blank string as well.
2. At this moment, we cannot make this field mandatory, as this would be a breaking change. However, we plan to designate it as a required field in version 12.

[preetibansalui]

Hey @preetibansalui
Just a question : Should the tooltip be rendered on UI if the string is empty ? I see warning is console but the tooltip renders with no content.
Im curious of useCase where consumers would want to pass an empty string for hidePasswordLabel/ ShowPasswordLabel. and Incase they do want an empty string, should we completely remove the tooltip itself ?

Hi @2nikhiltom, you've raised a valid point.

1. While there's no purpose in providing an empty string for the tooltip, users are still able to enter any value in the label field. Therefore, we need to handle for the case of a blank string as well.
2. At this moment, we cannot make this field mandatory, as this would be a breaking change. However, we plan to designate it as a required field in version 12.

Also, as per the a11y point of view, all clickable icons will have a tooltip. If no tooltip text is provided, a blank tooltip will be displayed.

[2nikhiltom]

It makes sense from a11y point of view, thanks Preeti

[emyarod]

looks good to me!