chore(datatable): remove duplicate setupGetInstanceId helper
#16990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
approved these changes
Jul 18, 2024
riddhybansal
approved these changes
Jul 22, 2024
riddhybansal
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
riddhybansal
added
status: merge conflict 🚫
and removed
status: ready to merge 🎉
labels
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Aug 9, 2024
e6d6fa4
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in #16988 that there are two nearly identical helpers named
setupGetInstanceId. Both were added a long time ago, but within 4 months of one another. One is used throughout the codebase, and one is only used in DataTable.The only difference is one is a function declaration, whereas the DataTable one is an arrow function.
Changelog
Changed
setupGetInstanceIdRemoved
setupGetInstanceIdin DataTable toolsTesting / Reviewing