Skip to content

[Bug]: eslint-config-carbon break from version 3.17.1 to 3.18 #18305

Closed
@davidmenendez

Description

@davidmenendez

Package

@carbon/react

Browser

No response

Package version

3.18

React version

18

Description

the latest carbon dependency PR in carbon for ibm products is failing. the update from version 3.17.1 to 3.18 is causing this error with our lint command

Oops! Something went wrong! :(

ESLint: 8.57.0

/home/runner/work/ibm-products/ibm-products/node_modules/eslint-config-carbon/rules/best-practices.js:10
export default {
^^^^^^

SyntaxError: Unexpected token 'export'
    at wrapSafe (node:internal/modules/cjs/loader:1378:20)
    at Module._compile (node:internal/modules/cjs/loader:1428:41)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at module.exports [as default] (/home/runner/work/ibm-products/ibm-products/node_modules/import-fresh/index.js:32:59)
    at loadJSConfigFile (/home/runner/work/ibm-products/ibm-products/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2583:47)
    at loadConfigFile (/home/runner/work/ibm-products/ibm-products/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2667:20)
    at ConfigArrayFactory._loadConfigData (/home/runner/work/ibm-products/ibm-products/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2984:42)

link to the failing build

please advise.

ps. eslint-carbon-config isn't a package option in the bug report template. may want to include it

Reproduction/example

https://github.com/carbon-design-system/ibm-products/actions/runs/12567020115/job/35033125614?pr=6634

Steps to reproduce

  1. clone ibm products
  2. install dependencies yarn
  3. update package.json with "eslint-config-carbon": "3.18.0",
  4. run yarn lint

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

ibm products

Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions