Skip to content

Defer running the state and action transforms #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Conversation

captbaritone
Copy link
Owner

Fixes #6.

@codecov-io
Copy link

codecov-io commented Apr 16, 2017

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          16     20    +4     
  Branches        5      6    +1     
=====================================
+ Hits           16     20    +4
Impacted Files Coverage Δ
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 181d2bc...04cad54. Read the comment docs.

@ChrisSargent
Copy link

All looks good to me - tested in my dev and the function is only called when submitting the error and the error is going through with the modified state so all looks good to me.

@captbaritone captbaritone merged commit 52a45f6 into master Apr 19, 2017
@captbaritone
Copy link
Owner Author

I will add some additional documentation to clarify how this works with user defined data callbacks and then cut a new release.

@captbaritone
Copy link
Owner Author

Thanks for prompting me to look into this again, and thanks for reviewing. 👏

@ChrisSargent
Copy link

No worries, thanks for the promptness!

@captbaritone
Copy link
Owner Author

Version 0.6.0 has been published.

@captbaritone captbaritone deleted the issue-6 branch April 20, 2017 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants