fix(authentication): Bad accessToken when signing in via Facebook under iOS
#843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nder iOS Replace classic facebook login with limited login.
…nder iOS Generate changeset.
…nder iOS Add definitions for app transparency methods.
…nder iOS Implement app transparency methods on ios.
…nder iOS Update changeset.
@capacitor-firebase/analytics
@capacitor-firebase/app
@capacitor-firebase/app-check
@capacitor-firebase/authentication
@capacitor-firebase/crashlytics
@capacitor-firebase/firestore
@capacitor-firebase/functions
@capacitor-firebase/messaging
@capacitor-firebase/performance
@capacitor-firebase/remote-config
@capacitor-firebase/storage
commit: |
…nder iOS Add logic to handle both classic and limited login.
…nder iOS Add docs to use classic facebook login.
robingenz
requested changes
Mar 15, 2025
packages/authentication/ios/Plugin/FirebaseAuthentication.swift
Outdated
Show resolved
Hide resolved
...authentication/ios/Plugin/Classes/Results/CheckAppTrackingTransparencyPermissionResult.swift
Outdated
Show resolved
Hide resolved
…nder iOS Return status with request app tracking call.
robingenz
requested changes
Mar 15, 2025
...authentication/ios/Plugin/Classes/Results/CheckAppTrackingTransparencyPermissionResult.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with a bad accessToken when signing in via Facebook on iOS by updating the signInWithFacebook API and adding support for Facebook Limited Login. It also introduces two new methods (checkAppTrackingTransparencyPermission and requestAppTrackingTransparencyPermission) to handle app tracking transparency on iOS, along with necessary documentation, type definitions, and platform-specific implementations.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/authentication/README.md | Updated signInWithFacebook signature and added documentation for the new iOS-specific APIs. |
| .changeset/happy-oranges-rush.md | Added a changeset entry for the iOS feature supporting Facebook Limited Login. |
| packages/authentication/docs/setup-facebook.md | Included instructions for setting NSUserTrackingUsageDescription in Info.plist. |
| packages/authentication/src/definitions.ts | Updated method signatures and type definitions for tracking transparency APIs. |
| packages/authentication/android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthenticationPlugin.java | Added stub implementations for tracking transparency methods that reject calls on Android. |
| packages/authentication/src/web.ts | Added stub implementations for tracking transparency methods that throw a not available error on web. |
…nder iOS Use restricted instead of prompt-with-rationale.
robingenz
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).Closes: #834