Skip to content

feat(crashlytics): recordException now supports stacktrace #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2022
Merged

feat(crashlytics): recordException now supports stacktrace #201

merged 1 commit into from
Sep 25, 2022

Conversation

NLueg
Copy link
Contributor

@NLueg NLueg commented Sep 8, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).

This PR includes the possiblity to inlcude stacktraces for Firebase.
This is basically the same PR as I created earlier here: capacitor-community/firebase-crashlytics#50

@robingenz
Copy link
Member

Thank you! I will have a look soon.

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@robingenz
Copy link
Member

@NLueg Please also fix the code linting:

npm run fmt

Maybe you need to update some files manually.

@robingenz robingenz added this to the v1.1.0 milestone Sep 24, 2022
@NLueg NLueg requested a review from robingenz September 25, 2022 10:22
@robingenz robingenz changed the title feat(stacktrace): adds option to submit a stacktrace for exceptions feat(crashlytics): recordException now supports stacktrace Sep 25, 2022
@robingenz robingenz merged commit 381bbfb into capawesome-team:main Sep 25, 2022
@github-actions github-actions bot mentioned this pull request Sep 25, 2022
@NLueg NLueg deleted the feat/crashlytics-stacktrace branch September 26, 2022 05:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants