Skip to content

test: drop brittle assertions #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

petrutlucian94
Copy link
Contributor

"validate_cis_hardening" explicitly checks the number of warnings and successful tests, which is extremely brittle. The microk8s CI is currently failing because of this.

We'll loosen those assertions and only check for expected failures.

Thank you for making MicroK8s better

Please reference the issue this PR is fixing, or provide a description of the problem addressed.

Also verify you have:

"validate_cis_hardening" explicitly checks the number of
warnings and successful tests, which is extremely brittle. The
microk8s CI is currently failing because of this.

We'll loosen those assertions and only check for expected failures.
@petrutlucian94
Copy link
Contributor Author

It was decided to actually keep those assertions and pin Pytest.

The following check produces different results when using versions other than the pinned one.

audit: "/bin/ps -ef | /bin/grep $etcdbin | /bin/grep -v grep"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant