lxd/bgp: Rework start/stop logic (from Incus) #15173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Mezhenskyi <[email protected]>
nmezhenskyi
changed the title
nmezhenskyi
force-pushed
the
fix-bgp-listener
branch
2 times, most recently
from
5fd468f to
74d89ab
Compare
tomponline
reviewed
Mar 14, 2025
This simplifies the BGP package a bit and improves on the ability to reconfigure it. The go-bgp ability to start/stop the daemon doesn't work reliably, so we need to spawn a completely new listener instead. This moves Start/Stop interactions to the main Reconfigure option and makes sure to always feed all peers and prefixes on startup. Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit 6a0d0137735c260b5872e27c7d94720e8d989228) Signed-off-by: Nikita Mezhenskyi <[email protected]> License: Apache-2.0
nmezhenskyi
force-pushed
the
fix-bgp-listener
branch
from
74d89ab to
f44d87f
Compare
nmezhenskyi
changed the title
Signed-off-by: Nikita Mezhenskyi <[email protected]>
simondeziel
previously approved these changes
Mar 15, 2025
Signed-off-by: Nikita Mezhenskyi <[email protected]>
tomponline
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
For future reference @nmezhenskyi we would want any corrections from code reviews to be rebased into the original commit not appended to the PR as an additional commit.
|
Thansk! |
|
@nmezhenskyi please update the cherry-pick doc, ta |
|
@nmezhenskyi please can you include lxc/incus#1805 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes cherry-pick from lxc/incus#1761.
Changes: